-
Notifications
You must be signed in to change notification settings - Fork 16
static attribute added to mapml-viewer #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks pretty good so far @Jacky0299! Seems to function nicely for all devices. I think disabling the zoom buttons was the right approach as users can always use the controlslist attribute to remove them if they wanted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor styling and test changes (make the same changes to mapml-viewer and web-map). You will need to make changes to the documentation also, you can link the web-map-doc PR to this PR when done. Good work on this!
AliyanH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Really good work, @Jacky0299! Thank you. Squash and merge when ready! |
|
Don't forget to do a "git pull upstream main" on your main local branch once you have merged upstream. |

new attribute!
closes #749.