Skip to content

Conversation

@Jacky0299
Copy link
Contributor

@Jacky0299 Jacky0299 commented Feb 15, 2023

new attribute!

closes #749.

@AliyanH
Copy link
Member

AliyanH commented Feb 15, 2023

Looks pretty good so far @Jacky0299! Seems to function nicely for all devices. I think disabling the zoom buttons was the right approach as users can always use the controlslist attribute to remove them if they wanted.
The map is still not fully 'static', for example clicking on a feature at the corner of the map, still pans the map to make the popup visible, but I don't thing this is a big issue:
Animation1
Similarly, users can also zoom to a layer (right click layer -> Zoom to Layer) to pan the map, though this can be controlled by the author as they can remove the layer control using the controlslist attribute.

@Jacky0299 Jacky0299 marked this pull request as ready for review February 16, 2023 15:33
Copy link
Member

@AliyanH AliyanH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor styling and test changes (make the same changes to mapml-viewer and web-map). You will need to make changes to the documentation also, you can link the web-map-doc PR to this PR when done. Good work on this!

@AliyanH AliyanH self-requested a review February 16, 2023 22:23
Copy link
Member

@AliyanH AliyanH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prushforth
Copy link
Member

Really good work, @Jacky0299! Thank you. Squash and merge when ready!

@prushforth
Copy link
Member

Don't forget to do a

"git pull upstream main" on your main local branch once you have merged upstream.

@Jacky0299 Jacky0299 merged commit 9730264 into Maps4HTML:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Static maps

3 participants