Skip to content

Disable Back, Forward, Reload when not possible #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 3, 2023
Merged

Disable Back, Forward, Reload when not possible #739

merged 3 commits into from
Feb 3, 2023

Conversation

@AliyanH
Copy link
Member

@AliyanH AliyanH commented Feb 2, 2023 •
edited
Loading

  • Disable Back, Forward, Reload when not possible
  • Update Tests
  • Add Tests
  • Change Back/Forward Logic, when you have a forward history present (after pressing back), panning the map/zooming in or out should remove the forward history and the new pan/zoom should be the most recent in the history stack.

closes #738.

@AliyanH AliyanH marked this pull request as ready for review February 3, 2023 20:34
@AliyanH AliyanH marked this pull request as draft February 3, 2023 20:44
@AliyanH AliyanH marked this pull request as ready for review February 3, 2023 20:56
@prushforth
Copy link
Member

prushforth commented Feb 3, 2023

LGTM!

AliyanH
AliyanH commented Feb 3, 2023
View reviewed changes
test/e2e/mapml-viewer/mapml-viewer.test.js
await page.click("body > mapml-viewer");
await page.keyboard.press('Control+v');
await page.waitForTimeout(500);
await page.waitForTimeout(1000);
Copy link
Member Author

@AliyanH AliyanH Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to fix flakiness, progresses #729.

@AliyanH AliyanH merged commit 78b3ae1 into Maps4HTML:main Feb 3, 2023
@AliyanH AliyanH deleted the ContextmenuItems branch February 3, 2023 21:52
prushforth pushed a commit to kevinkim31/Web-Map-Custom-Element that referenced this pull request Feb 5, 2023
@AliyanH @prushforth
Disable Back, Forward, Reload when not possible (Maps4HTML#739)
ba5f88e 
* Disable Back, Forward, Reload when not possible + update tests

* Add disabled contextmenu items' test

* Update history stack to overwrite forward history when history changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Disable Back, Forward, and Reload contextmenu items when no history present

2 participants

@AliyanH @prushforth