Skip to content

Conversation

@prushforth
Copy link
Member

@prushforth prushforth commented Dec 11, 2022

  • get integration tests working
  • get unit tests working
  • supply source maps if possible
  • apply diff patch during copy of proj4leaflet.js instead of owning that dependency

helps progress #153

prushfor and others added 3 commits December 10, 2022 15:55
Still need to add source maps, to facilitate debugging tbd.
proj4leaflet.js source until I figure out the patching process. See
README in new folder for details.
@prushforth prushforth marked this pull request as draft December 11, 2022 01:10
@prushforth prushforth marked this pull request as ready for review December 12, 2022 02:17
@prushforth prushforth requested a review from AliyanH December 12, 2022 02:17
Copy link
Member

@AliyanH AliyanH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! This uglification helps reduce the dist directory's size by 60%. Like @prushforth mentioned in our discussions, this can be reduced further in the future using other minification techniques such as "tree-shaking".

Good performance improvement, helps progress #153

@prushforth prushforth merged commit 8b40f10 into Maps4HTML:main Dec 12, 2022
@prushforth prushforth deleted the uglify branch December 12, 2022 19:26
@prushforth prushforth mentioned this pull request Dec 12, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants