All-benchmarks script and CI workflow improvements#758
Merged
ghzlatarev merged 8 commits intomantafrom Aug 25, 2022
Merged
Conversation
…ven if previous steps failed in all CI workflows. Disable parachain block time parsing temporarily Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Apokalip
previously approved these changes
Aug 19, 2022
Contributor
Apokalip
left a comment
There was a problem hiding this comment.
Looks pretty good to me! Now it looks a little cleaner than before and the tests' always() is a good change as we would want to see not only until the failing test
Contributor
@Garandor |
Garandor
reviewed
Aug 19, 2022
Garandor
previously approved these changes
Aug 19, 2022
Contributor
Garandor
left a comment
There was a problem hiding this comment.
LGTM, maybe get rid of the yamllint warning before merge @ghzlatarev
Dengjianping
previously approved these changes
Aug 22, 2022
Contributor
Dengjianping
left a comment
There was a problem hiding this comment.
LGTM, but there's conflict to be resolved.
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
e2883a8
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Garandor
approved these changes
Aug 24, 2022
Dengjianping
approved these changes
Aug 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Georgi Zlatarev georgi.zlatarev@manta.network
Description
closes: #759
Adds a
run_all_benchmarks.shscript which runs pallet, storage and machine benchmark and outputs results, same as this Parity script Create Script to Run All Benchmarks paritytech/substrate#11493Adds new CI workflow which calls the script and replaces the 3 duplicated weights benchmarking workflows for dolphin, calamari and manta.
The chain-spec is a mandatory input field on the new workflow.
The storage benchmark can be skipped if no URL is provided for the second input field that specifies a tar.gz archive of a production chain snapshot.
Changed all CI workflows to always try to upload artifacts even if previous steps have failed, which is useful for debugging failed jobs.
Disable parachain block parsing until polkadot-js recognizes we that our chain is a special case like Moonbeam with nimbus keys.
Update release process template to account for aforementioned changes.
Example run - https://github.com/Manta-Network/Manta/runs/7880566445?check_suite_focus=true
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
L-group to this PRA-andC-groups to this PRFiles changedin the Github PR explorer.Situational Notes:
BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]items to check for any.authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run themetadata_diff.ymlworkflow for help. If this number is updated, then thespec_versionmust also be updated