Expose 9945 for checking relaychain's block number on parachain#435
Merged
Dengjianping merged 9 commits intomantafrom Mar 11, 2022
Merged
Expose 9945 for checking relaychain's block number on parachain#435Dengjianping merged 9 commits intomantafrom
Dengjianping merged 9 commits intomantafrom
Conversation
Signed-off-by: Dengjianping <djptux@gmail.com>
ghzlatarev
approved these changes
Mar 8, 2022
Contributor
ghzlatarev
left a comment
There was a problem hiding this comment.
I'm fine with this workaround, if no one can find a solution.
Contributor
Author
|
I think we should move bootnodes to genesis. It's not that convenient for node runners who have to append bootnodes while a node is started. |
Contributor
Author
|
I built image with the new genesis, it works fine, and can sync blocks from mainnet. |
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
c646100 to
3fca832
Compare
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
368ceb8 to
700ce04
Compare
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
Contributor
|
the hotdog node key is actually |
ghzlatarev
reviewed
Mar 11, 2022
Signed-off-by: Dengjianping <djptux@gmail.com>
ghzlatarev
approved these changes
Mar 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dengjianping djptux@gmail.com
Description
Currently seems docker cannot parse bootnodes inENTRYPOINT.Originally,ENTRYPOINTin dockerfile like this:Previously it worked fine.But now, it failed to parse bootnodes inENTRYPOINT. So our CI always gets error on docker image check.Removing them, it worked.Expose port
9945to improve CI on checking relaychain's blocks.closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
mantaordolphin) with right title (start with [Manta] or [Dolphin]),<branch>/CHANGELOG.mdFiles changedin the Github PR explorer.authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updatedversionfor every crate.BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime.