Open
Conversation
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Jamie <djptux@gmail.com>
Dengjianping
added
C-enhancement
Signed-off-by: Jamie <djptux@gmail.com>
Comment on lines
+419
to
+422
| ProxyType::TransferNotDie => !matches!( | ||
| c, | ||
| RuntimeCall::Balances(pallet_balances::Call::transfer_allow_death { .. }) | ||
| ), // proxy account cannot transfer all |
Contributor
There was a problem hiding this comment.
this will allow all calls that are not pallet_balances::Call::transfer_allow_death { .. }, I don't think you can use the !matches pattern for that reason
Contributor
There was a problem hiding this comment.
unless I'm mistaken but I think we would want a sanity integration test
Contributor
Author
There was a problem hiding this comment.
fasle means the call will be filtered, so if it's the transfer_allow_death, !matches will be false. I guess it should be right. I will add a test case for it.
Contributor
There was a problem hiding this comment.
yeah but any other call will be true, this means that TransferNotDie will allow you to act as a proxy for every other extrinsic except transfer_allow_death
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1321
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-group to this PRA-andC-groups to this PRA-calamariand/orA-mantaif your changes are meant for/impact either of these (CI depends on it)Files changedin the Github PR explorer.A-integration-test-checksto run start-integration-test-checks (Required)A-benchmark-checksto run start-benchmark-check (Required)A-unit-test-checksto run start-unit-test-checks (Required)A-congestion-test-checksto run start-integration-test-checks (Optional)Situational Notes:
BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]items to check for any.