Skip to content

Bump srtool#1282

Merged
Dengjianping merged 1 commit intomantafrom
bump-srtool
Dec 25, 2023
Merged

Bump srtool#1282
Dengjianping merged 1 commit intomantafrom
bump-srtool

Conversation

@Dengjianping
Copy link
Copy Markdown
Contributor

@Dengjianping Dengjianping commented Dec 25, 2023

Description

We have to bump srtool to build our runtime.

║ error: package `clap_lex v0.6.0` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.66.1
  ║ Either upgrade to rustc 1.70.0 or newer, or use
  ║ cargo update -p clap_lex@0.6.0 --precise ver
  ║ where `ver` is the latest version of `clap_lex` supporting rustc 1.66.1

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping merged commit 5ea7262 into manta Dec 25, 2023
@Dengjianping Dengjianping deleted the bump-srtool branch December 25, 2023 08:22
anaye1997 pushed a commit that referenced this pull request Dec 26, 2023
Signed-off-by: Dengjianping <djptux@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants