Skip to content

🚀 update public draft releases trigger condition#1281

Merged
Dengjianping merged 1 commit intomantafrom
feature/update-public-draft-release-trigger-condition-2
Dec 25, 2023
Merged

🚀 update public draft releases trigger condition#1281
Dengjianping merged 1 commit intomantafrom
feature/update-public-draft-release-trigger-condition-2

Conversation

@anaye1997
Copy link
Copy Markdown
Contributor

@anaye1997 anaye1997 commented Dec 25, 2023

Signed-off-by: Anathan (Ana) Ye anaye@duck.com

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Anathan (Ana) Ye <anaye@duck.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 25, 2023

⚠️ Congestion test: 1-day congestion cost (manta-runtime) is NOT above the target daily congestion cost

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 25, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

@Dengjianping Dengjianping merged commit 7f0e407 into manta Dec 25, 2023
@Dengjianping Dengjianping deleted the feature/update-public-draft-release-trigger-condition-2 branch December 25, 2023 07:56
anaye1997 added a commit that referenced this pull request Dec 26, 2023
Signed-off-by: Anathan (Ana) Ye <anaye@duck.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants