Skip to content

split lottery repo#1248

Open
zqhxuyuan wants to merge 3 commits intomantafrom
lotter_split
Open

split lottery repo#1248
zqhxuyuan wants to merge 3 commits intomantafrom
lotter_split

Conversation

@zqhxuyuan
Copy link
Copy Markdown
Contributor

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@zqhxuyuan zqhxuyuan changed the title split lotter repo split lottery repo Aug 17, 2023
@zqhxuyuan zqhxuyuan added L-removed Log: Issues and PRs related to removing something A-manta Area: Issues and PRs related to the Manta Runtime C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-changed Log: Issues and PRs related to changes and removed L-removed Log: Issues and PRs related to removing something labels Aug 17, 2023
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-changed Log: Issues and PRs related to changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants