Skip to content

Implement MaxEncodedLen wherever necessary #387

@ghzlatarev

Description

@ghzlatarev

currently without_storage_info is used in all Pallets that do not implement MaxEncodedLen
paritytech/substrate#10662
Essentially without_storage_info means that the storage consumption of this pallet is unbounded.
As part of this big PoV benchmarking issue paritytech/polkadot-sdk#398, they added a trait StorageInfoTrait that every storage should implement (on condition that value and keys implement MaxEncodedLen) paritytech/substrate#8735
Originally you had to use the generate_storage_info attribute to make a pallet implement the StorageInfoTrait. Since this shouldn't be missed in new pallets they made it implement by default, but now keys and values that don't implement MaxEncodedLen will not compile. So the without_storage_info attribute is used to skip implementation of StorageInfoTrait until MaxEncodedLen is implemented wherever necessary. paritytech/substrate#10662

Enabling this will allow us to adopt the following test:
paritytech/substrate#11699

Metadata

Metadata

Assignees

Labels

A-runtimeArea: Issues and PRs related to RuntimesC-good-first-issueCategory: Good first issuesP-mediumPriority: Medium

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions