Revert "move to libtest" #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 64ecab2.
Owner
Author
|
This is broken on nightly, however it works on rustc master (so it will automatically be fixed in the next nightly). As the main nightly user is clippy (which uses rustc master), I'm going to go ahead and merge this. Fixing all this is a bit urgent since we don't want to break the upcoming beta. |
Contributor
|
To make CI pass on nightly will require #170 to land, but that should be no issue for reverse dependencies. |
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Apr 7, 2019
Revert compiletest hacks, use latest compiletest The libtest changes have been reverted, see rust-lang/rust#59766, Manishearth/compiletest-rs#174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We reverted the libtest changes in rustc (rust-lang/rust#59766 (comment)), this reverts the change made here to use libtest, allowing us to finally build on stable and nightly again.