[EUWE] Removed code artifact in Central Admin UI#14879
Merged
simaishi merged 1 commit intoManageIQ:euwefrom May 3, 2017
Merged
[EUWE] Removed code artifact in Central Admin UI#14879simaishi merged 1 commit intoManageIQ:euwefrom
simaishi merged 1 commit intoManageIQ:euwefrom
Conversation
Author
|
@miq-bot add_label bug |
himdel
approved these changes
Apr 25, 2017
Contributor
himdel
left a comment
himdel
left a comment
There was a problem hiding this comment.
Agreed, the form is identical to before (except for .modal.fade and :novalidate => true in the original, and a message about ssh_host being required in the new version), but no :cdata so no artifacts 👍
Author
|
before: after: |
Member
|
Checked commit jzigmund@fe9efae with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Contributor
|
(Test failures will go away once #14871 is merged.) |
Contributor
|
@jzigmund you may want to restart travis, should pass now.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is removing the code artifact from the Central Admin form. Created with @himdel assistance, we removed the inline HTML and moved
app/views/ops/_authkey_modal_form.html.hamltoapp/views/static/authkey_modal_form.html.hamland set it as template inpglogicalReplicationFormControllerThe Central Admin has been removed from fine/master branch by ManageIQ/manageiq-ui-classic#421
https://bugzilla.redhat.com/show_bug.cgi?id=1441401