This repository was archived by the owner on Apr 7, 2022. It is now read-only.
[WIPTEST] Added fixture to validate repo url from yaml#9917
Open
ganeshhubale wants to merge 1 commit intoManageIQ:masterfrom
Open
[WIPTEST] Added fixture to validate repo url from yaml#9917ganeshhubale wants to merge 1 commit intoManageIQ:masterfrom
ganeshhubale wants to merge 1 commit intoManageIQ:masterfrom
Conversation
Contributor
|
I detected some fixture changes in commit ad253517aa6eb4811023d4a41b9939aba35253b0 The local fixture
The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
2649345 to
26accb1
Compare
88be821 to
3cf0d13
Compare
83c7e61 to
2faebc4
Compare
jarovo
suggested changes
Feb 24, 2020
cfme/automate/explorer/domain.py
Outdated
Contributor
There was a problem hiding this comment.
Required: I don't think there is a reason for use of delattr when we can use del
Suggested change
| delattr(self.obj, "locked") | |
| del self.obj.locked |
This may help with code analysis in some code editors and re-factoring tools.
Signed-off-by: Ganesh Hubale <[email protected]>
2faebc4 to
fe405a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ganesh Hubale [email protected]
Purpose or Intent
test_git_import.pyby adding fixture to validategit repo urlfromcfme_data.ymlfilePRT Run
{{ pytest: cfme/tests/automate/test_git_import.py -k 'test_automate_git_domain_removed_from_disk or test_automate_git_domain_displayed_in_service or test_automate_git_import_multiple_domains or test_domain_import_git or test_domain_import_git_rest or test_automate_git_import_case_insensitive or test_automate_git_domain_import_connection or test_automate_git_import_without_master or test_git_refresh_with_renamed_yaml' -vvv }}