This repository was archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Tests tagging on provider side#8543
Merged
izapolsk merged 3 commits intoManageIQ:masterfrom Mar 29, 2019
Merged
Conversation
Contributor
|
PRT errors: |
lina-is-here
reviewed
Mar 7, 2019
mshriver
force-pushed
the
rlbabyuk-test-map-tagging
branch
from
b502e48 to
b9231b0
Compare
lina-is-here
reviewed
Mar 7, 2019
mshriver
force-pushed
the
rlbabyuk-test-map-tagging
branch
from
013822c to
304b84e
Compare
mshriver
changed the title
lina-is-here
changed the title
Contributor
|
@mshriver please check PRT failures |
mshriver
force-pushed
the
rlbabyuk-test-map-tagging
branch
from
fc84586 to
984409e
Compare
mshriver
changed the title
mshriver
force-pushed
the
rlbabyuk-test-map-tagging
branch
from
984409e to
5e7d06c
Compare
mshriver
changed the title
digitronik
reviewed
Mar 22, 2019
digitronik
reviewed
Mar 22, 2019
jawatts
changed the title
Rebased from Ruslana Babyuk's original commits, updated for more recent test patterns
Add casecomponent Tagging, update test case docblocks Update MapTag.delete table row filter, fix test_tag update call Update test fixtures and REST test failure handling for tag tests
mshriver
force-pushed
the
rlbabyuk-test-map-tagging
branch
from
5e7d06c to
676e900
Compare
mshriver
changed the title
Member
Author
|
@ganeshhubale @lina-nikiforova @digitronik please take another look, addressed the comments. At this point there are some PRT failures, but I would like the FA owner to address those. |
digitronik
approved these changes
Mar 28, 2019
Contributor
digitronik
left a comment
digitronik
left a comment
There was a problem hiding this comment.
@mshriver LGTM 👍 Thanks for this PR.
Just one personal request and string formatting. Moving to 1LP WIPTEST
| current_tag_value = view.entities.summary('Labels').get_text_of(tag_label) | ||
| soft_assert( | ||
| current_tag_value == tag_value, ( | ||
| 'Tag values is not that expected, actual - {}, expected - {}'.format( |
Contributor
There was a problem hiding this comment.
keying please for such formatting.
I would catch msg in variable for better readability.
digitronik
changed the title
mshriver
changed the title
Contributor
|
LGTM, I will look further into the failures in a separate PR as it's my FA |
lina-is-here
approved these changes
Mar 28, 2019
izapolsk
approved these changes
Mar 29, 2019
Contributor
|
since changes look good to me and @lina-nikiforova promises to handle failed PRT, I'm merging this PRT. |
lina-is-here
pushed a commit
to lina-is-here/integration_tests
that referenced
this pull request
May 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased from Ruslana Babyuk's original commits in #7320, updated for more recent test patterns.
I would like to leave any remaining test failures to the FA owner to address.
{{ pytest: --long-running -vvvv --use-provider complete cfme/tests/cloud/test_tag_mapping.py cfme/tests/configure/test_tag.py }}