This repository was archived by the owner on Apr 7, 2022. It is now read-only.
[RFR] Add module-scoped replicated_appliances fixture#10312
Merged
mshriver merged 1 commit intoManageIQ:masterfrom Sep 10, 2020
tpapaioa:add_modscope_multi_appliance_fixtures
Merged
[RFR] Add module-scoped replicated_appliances fixture#10312mshriver merged 1 commit intoManageIQ:masterfrom tpapaioa:add_modscope_multi_appliance_fixtures
mshriver merged 1 commit intoManageIQ:masterfrom
tpapaioa:add_modscope_multi_appliance_fixtures
Conversation
Contributor
|
I detected some fixture changes in commit e747dbc The global fixture
The global fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
mshriver
approved these changes
Sep 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added module-scoped multi-region appliance fixture
replicated_appliances_modscope, and replaced the function-scoped with this new module-scoped fixture in the tests incfme/tests/distributed/test_appliance_replication.py. Because the tests previously didn't have to worry about cleanup, I've also added some finalizers to remove provider and other records after each test.{{ pytest: --long-running --use-provider complete -k 'test_replication_ or test_appliance_replicate_' cfme/tests/distributed/test_appliance_replication.py }}