This repository was archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Automating dialog test details view#10283
Merged
digitronik merged 1 commit intoManageIQ:masterfrom Aug 6, 2020
Merged
[1LP][RFR] Automating dialog test details view#10283digitronik merged 1 commit intoManageIQ:masterfrom
digitronik merged 1 commit intoManageIQ:masterfrom
Conversation
valaparthvi
approved these changes
Aug 5, 2020
Contributor
valaparthvi
left a comment
There was a problem hiding this comment.
2 optional comments, LGTM otherwise!
Contributor
There was a problem hiding this comment.
Don't really need to assert the is_displayed property, it will be done by navigate_to, so you can just put navigate_to(sd, "Details") under the logvalidator.
Contributor
There was a problem hiding this comment.
This step seems a little redundant to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run
{{pytest: cfme/tests/services/test_dialog_element_in_catalog.py::test_navigate_details_dialog_view }}