Skip to content
This repository was archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Automating dialog test details view#10283

Merged
digitronik merged 1 commit intoManageIQ:masterfrom
niyazRedhat:dialog-t
Aug 6, 2020
Merged

[1LP][RFR] Automating dialog test details view#10283
digitronik merged 1 commit intoManageIQ:masterfrom
niyazRedhat:dialog-t

Conversation

@niyazRedhat
Copy link
Contributor

@niyazRedhat niyazRedhat commented Aug 5, 2020

Purpose or Intent

PRT Run

{{pytest: cfme/tests/services/test_dialog_element_in_catalog.py::test_navigate_details_dialog_view }}

  • automated test_edit_dialog_1834219
  • removed already covered and non-required test

@niyazRedhat niyazRedhat changed the title [WIPTEST] Automating dialog test details view [RFR] Automating dialog test details view Aug 5, 2020
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 optional comments, LGTM otherwise!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really need to assert the is_displayed property, it will be done by navigate_to, so you can just put navigate_to(sd, "Details") under the logvalidator.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step seems a little redundant to me.

@valaparthvi valaparthvi changed the title [RFR] Automating dialog test details view [1LP][RFR] Automating dialog test details view Aug 5, 2020
@digitronik digitronik added the test-automation To be applied on PR's which are automating existing manual cases label Aug 6, 2020
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@digitronik digitronik merged commit 0e8f081 into ManageIQ:master Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

test-automation To be applied on PR's which are automating existing manual cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants