This repository was archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Fix dangerous arg value#10274
Merged
mshriver merged 1 commit intoManageIQ:masterfrom Jul 31, 2020
jarovo:fix_dangerous_arg_value
Merged
[1LP][RFR] Fix dangerous arg value#10274mshriver merged 1 commit intoManageIQ:masterfrom jarovo:fix_dangerous_arg_value
mshriver merged 1 commit intoManageIQ:masterfrom
jarovo:fix_dangerous_arg_value
Conversation
john-dupuy
approved these changes
Jul 31, 2020
mshriver
approved these changes
Jul 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using mutable as default arg value is dangerous as it is evaluated once, when function is being created (module loaded).
This value is preserved between each function calls and when modified, the subsequent calls will use the new state of that default object.