[RFR] Automate test: test_reports_in_global_region

[valaparthvi]

Purpose or Intent

• Adding tests
  1. test_reports_in_global_region.
• Enhancement
  1. Add rest_api_entity property to Report.
  2. cfme/tests/intelligence/reports/test_reports.py::report fixture to take custom appliance
  3. Add fixtures -
     1. cfme/fixtures/appliance.py::temp_appliance_preconfig_modscope_rhevm
     2. cfme/fixtures/cli.py::replicated_appliances_modscope

PRT Run

{{ pytest: cfme/tests/intelligence/reports/test_reports.py::test_reports_in_global_region -svvv --long-running}}

[valaparthvi]

@tpapaioa can you review this?

[tpapaioa]

Instead of setting up some of the appliances in replicated_appliances_modscope and some of them here, I think it would make more sense to have all of the db configuration and replication configuration in one fixture. The fixtures in cfme/fixtures/multi_region.py could be used here; multi_region_cluster can pass an indirect parameter to temp_appliances_unconfig_modscope_rhevm to specify the total number of appliances, and setup_multi_region_cluster takes care of configuring all of them. There is also a setup_remote_provider fixture that could be copied or modified to set up providers on multiple remote appliances.

[valaparthvi]

This was awesome! Thanks for the suggestions @tpapaioa, let me know how it looks now.

[tpapaioa]

Looks good. Just two small additional comments:

• setup_providers_on_multi_region_cluster returns multi_region_cluster as the third tuple entry, even though the fixture didn't create or modify it. This fixture should just return the two providers, and if the test or any other fixtures / methods need multi_region_cluster, they can accept it as a separate parameter.

• temp_appliances_unconfig_modscope_rhevm doesn't need to be in the parameter list for test_reports_in_global_region, since it's not used in the test method and is already called during the setup of multi_region_cluster. The indirect parametrize call will still work as is.

[dajoRH]

I detected some fixture changes in commit 14df6a1

The local fixture setup_providers_on_multi_region_cluster is used in the following files:

• cfme/tests/intelligence/reports/test_reports.py

The local fixture saved_report is used in the following files:

• cfme/tests/intelligence/reports/test_reports.py

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

[valaparthvi]

@tpapaioa updated. I can't believe I missed out on those things you suggested while writing the test 🤦

[tpapaioa]

Looks good to me.