Skip to content
This repository was archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] - Test to check schedule task more than one time#10239

Merged
digitronik merged 1 commit intoManageIQ:masterfrom
dgaikwad:test_automate_task_schedule
Jul 13, 2020
Merged

[1LP][RFR] - Test to check schedule task more than one time#10239
digitronik merged 1 commit intoManageIQ:masterfrom
dgaikwad:test_automate_task_schedule

Conversation

@dgaikwad
Copy link

@dgaikwad dgaikwad commented Jul 7, 2020

adding_test Adding test to check scheduler working or not more than one time

Purpose or Intent

PRT Run

{{pytest: cfme/tests/automate/test_method.py::test_automate_task_schedule cfme/tests/configure/test_schedule_operations.py --long-running -v}}

@dgaikwad dgaikwad force-pushed the test_automate_task_schedule branch from 4aa26f7 to 54a7bad Compare July 7, 2020 06:15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if you just take UTC timezone? Appliance anyway uses that timezone.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the scheduler works based on timezone and datetime so need correct timezone and date time

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dgaikwad dgaikwad force-pushed the test_automate_task_schedule branch 3 times, most recently from 2b0eaff to e1854aa Compare July 8, 2020 10:55
@dgaikwad dgaikwad changed the title [WIPTEST] - Test to check schedule task more than one [RFR] - Test to check schedule task more than one Jul 8, 2020
@dgaikwad dgaikwad changed the title [RFR] - Test to check schedule task more than one [WIPTEST] - Test to check schedule task more than one Jul 8, 2020
@dgaikwad dgaikwad force-pushed the test_automate_task_schedule branch from e1854aa to e60a381 Compare July 8, 2020 11:52
@dgaikwad dgaikwad changed the title [WIPTEST] - Test to check schedule task more than one [RFR] - Test to check schedule task more than one Jul 8, 2020
@dgaikwad dgaikwad requested a review from valaparthvi July 8, 2020 13:17
@dgaikwad dgaikwad changed the title [RFR] - Test to check schedule task more than one [RFR] - Test to check schedule task more than one time Jul 9, 2020
@valaparthvi valaparthvi changed the title [RFR] - Test to check schedule task more than one time [1LP][RFR] - Test to check schedule task more than one time Jul 9, 2020
@digitronik digitronik self-assigned this Jul 9, 2020
@dgaikwad dgaikwad force-pushed the test_automate_task_schedule branch from e60a381 to 0d9b63f Compare July 9, 2020 15:07
@dgaikwad dgaikwad changed the title [1LP][RFR] - Test to check schedule task more than one time [1LP][WIPTEST] - Test to check schedule task more than one time Jul 9, 2020
@dgaikwad dgaikwad changed the title [1LP][WIPTEST] - Test to check schedule task more than one time [1LP][RFR] - Test to check schedule task more than one time Jul 10, 2020
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions

@digitronik digitronik changed the title [1LP][RFR] - Test to check schedule task more than one time [1LP][WIPTEST] - Test to check schedule task more than one time Jul 10, 2020
@dgaikwad dgaikwad force-pushed the test_automate_task_schedule branch from 0d9b63f to 76bb05e Compare July 10, 2020 10:20
@dgaikwad dgaikwad force-pushed the test_automate_task_schedule branch from 76bb05e to 658ed4f Compare July 10, 2020 12:55
@dajoRH
Copy link
Contributor

dajoRH commented Jul 10, 2020

I detected some fixture changes in commit 658ed4f

The global fixture current_server_time is used in the following files:

  • cfme/tests/automate/test_method.py
    • test_automate_task_schedule
  • cfme/tests/configure/test_schedule_operations.py
    • test_schedule_crud
    • test_schedule_analysis_in_the_past
    • test_inactive_schedule
    • test_schedule_timer

The local fixture custom_automate_setup is used in the following files:

  • cfme/tests/automate/test_method.py
    • test_automate_task_schedule

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@dgaikwad dgaikwad changed the title [1LP][WIPTEST] - Test to check schedule task more than one time [1LP][RFR] - Test to check schedule task more than one time Jul 13, 2020
@digitronik digitronik merged commit af70d06 into ManageIQ:master Jul 13, 2020
@digitronik digitronik added fix-locator-or-text test-automation To be applied on PR's which are automating existing manual cases labels Jul 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

fix-locator-or-text test-automation To be applied on PR's which are automating existing manual cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants