This repository was archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Fix setting logger level from config#10224
Merged
mshriver merged 1 commit intoManageIQ:masterfrom Jun 30, 2020
tpapaioa:fix_logger_level
Merged
[1LP][RFR] Fix setting logger level from config#10224mshriver merged 1 commit intoManageIQ:masterfrom tpapaioa:fix_logger_level
mshriver merged 1 commit intoManageIQ:masterfrom
tpapaioa:fix_logger_level
Conversation
jarovo
approved these changes
Jun 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loggers created via
cfme.utils.log.setup_loggerwere hardcoded to have theINFOlog level, ignoring any settings inconf/env.local.yaml. The associated file handlers do get created with the level from the yaml, but because the logger's level is fixed atINFO, noDEBUGlogging is possible. This PR uses the yaml settings when creating the logger too, so that settings like the following inconf/env.local.yamlwill log debug statements incfme.log.