Skip to content
This repository was archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] New test: TestZoneRESTAPI and TestServerRESTAPI#10215

Merged
mshriver merged 1 commit intoManageIQ:masterfrom
valaparthvi:server_zone_api
Jul 1, 2020
Merged

[1LP][RFR] New test: TestZoneRESTAPI and TestServerRESTAPI#10215
mshriver merged 1 commit intoManageIQ:masterfrom
valaparthvi:server_zone_api

Conversation

@valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented Jun 26, 2020

Purpose or Intent

  • Extending

    1. Add basic_information to ZoneSettingsView.zone.
    2. Add rest_api_entity property to Zone.
    3. Remove basic_information_values method since it's not used anywhere.
  • Adding tests

    1. TestZoneRESTAPI
    2. TestServerRESTAPI

PRT Run

{{ pytest: cfme/tests/configure/test_rest_config.py -k "TestServerRESTAPI or TestZoneRESTAPI" -svvv }}

@valaparthvi valaparthvi force-pushed the server_zone_api branch 5 times, most recently from 17ae4ad to d9bd440 Compare June 28, 2020 10:32
@valaparthvi valaparthvi changed the title [WIPTEST] New test: TestZoneRESTAPI and TestServerRESTAPI [RFR] New test: TestZoneRESTAPI and TestServerRESTAPI Jun 29, 2020
Copy link
Member

@ganeshhubale ganeshhubale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for automation @valaparthvi
LGTM 💯

@john-dupuy john-dupuy changed the title [RFR] New test: TestZoneRESTAPI and TestServerRESTAPI [1LP][RFR] New test: TestZoneRESTAPI and TestServerRESTAPI Jun 30, 2020
@dajoRH
Copy link
Contributor

dajoRH commented Jul 1, 2020

I detected some fixture changes in commit b5861f9

The local fixture zone is used in the following files:

  • cfme/tests/configure/test_rest_config.py
    • test_create_zone
    • test_edit_zone
    • test_delete_zone_from_detail
    • test_delete_zone_from_collections
    • test_delete_assigned_zone

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@mshriver mshriver merged commit 6784d9d into ManageIQ:master Jul 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants