Skip to content
This repository was archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] New test:test_edit_zone#10213

Merged
mshriver merged 1 commit intoManageIQ:masterfrom
valaparthvi:region_api
Jun 29, 2020
Merged

[1LP][RFR] New test:test_edit_zone#10213
mshriver merged 1 commit intoManageIQ:masterfrom
valaparthvi:region_api

Conversation

@valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented Jun 25, 2020

Purpose or Intent

  • Extending

    1. Add rest_api_entity property for region.
    2. Modify settings_string and region_string to return the correct value even when region description is not set to default.
  • Adding tests

    1. test_edit_zone covering BZ(1805844)

PRT Run

{{ pytest: cfme/tests/configure/test_rest_config.py::test_edit_region -svvv}

@valaparthvi valaparthvi requested a review from digitronik June 25, 2020 18:41
@valaparthvi valaparthvi changed the title [WIPTEST] New test:test_edit_zone [WIP] New test:test_edit_zone Jun 25, 2020
@valaparthvi valaparthvi changed the title [WIP] New test:test_edit_zone [WIPTEST] New test:test_edit_zone Jun 26, 2020
@valaparthvi valaparthvi removed the request for review from digitronik June 26, 2020 06:14
@valaparthvi valaparthvi force-pushed the region_api branch 2 times, most recently from bf4a100 to 13b3657 Compare June 26, 2020 07:16
@valaparthvi valaparthvi changed the title [WIPTEST] New test:test_edit_zone [RFR] New test:test_edit_zone Jun 26, 2020
Copy link
Member

@ganeshhubale ganeshhubale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Please check Travis checks.

@ganeshhubale ganeshhubale changed the title [RFR] New test:test_edit_zone [1LP][RFR] New test:test_edit_zone Jun 26, 2020
@valaparthvi valaparthvi force-pushed the region_api branch 2 times, most recently from 396cf81 to 8555a34 Compare June 26, 2020 16:56
@mshriver mshriver merged commit 0700b36 into ManageIQ:master Jun 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants