This repository was archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Adding dialog text area regex validation test#10200
Merged
mshriver merged 1 commit intoManageIQ:masterfrom Jul 1, 2020
Merged
[1LP][RFR] Adding dialog text area regex validation test#10200mshriver merged 1 commit intoManageIQ:masterfrom
mshriver merged 1 commit intoManageIQ:masterfrom
Conversation
niyazRedhat
changed the title
john-dupuy
added
the
test-automation
john-dupuy
reviewed
Jun 19, 2020
john-dupuy
changed the title
niyazRedhat
changed the title
john-dupuy
approved these changes
Jun 26, 2020
Contributor
john-dupuy
left a comment
john-dupuy
left a comment
There was a problem hiding this comment.
LGTM, nice use of parametrization 👍
john-dupuy
changed the title
mshriver
reviewed
Jun 29, 2020
Member
There was a problem hiding this comment.
I don't think this is behaving quite in the way you intended.
the value for the dict field will be set to the boolean result of hasattr() and request.param.get() - not the string value of request.param.get()
mshriver
suggested changes
Jun 29, 2020
Member
mshriver
left a comment
mshriver
left a comment
There was a problem hiding this comment.
Suspect behavior within the modified fixture, not sure how/why the test passed anyway?
mshriver
changed the title
Contributor
|
I detected some fixture changes in commit a983062 The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
niyazRedhat
changed the title
mshriver
reviewed
Jul 1, 2020
| @pytest.fixture(scope="function") | ||
| def dialog_cat_item(appliance, catalog, request): | ||
| default_data = {"choose_type": "Text Box", "validation": "^([a-z0-9]+_*)*[a-z0-9]+$"} | ||
| data = getattr(request, "param", default_data) |
Member
There was a problem hiding this comment.
Nice fix, this pattern is much better.
mshriver
approved these changes
Jul 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run
{{pytest: cfme/tests/services/test_dialog_regex_validation_in_catalog.py::test_dialog_element_regex_validation }}