This repository was archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] - check Key Pair list using aws provider#10188
Merged
digitronik merged 1 commit intoManageIQ:masterfrom Jun 18, 2020
Merged
[1LP][RFR] - check Key Pair list using aws provider#10188digitronik merged 1 commit intoManageIQ:masterfrom
digitronik merged 1 commit intoManageIQ:masterfrom
Conversation
dgaikwad
force-pushed
the
test_aws_keypair_list
branch
from
a7e811e to
d264757
Compare
dgaikwad
changed the title
dgaikwad
force-pushed
the
test_aws_keypair_list
branch
from
d264757 to
56e658b
Compare
dgaikwad
changed the title
tpapaioa
suggested changes
Jun 11, 2020
Contributor
There was a problem hiding this comment.
The parentheses aren't needed here.
Contributor
There was a problem hiding this comment.
I don't see any difference between these two values. Also, since 5.10 and earlier versions are no longer being run against master, there's no need for version checking.
Contributor
There was a problem hiding this comment.
Use the automates keyword instead of coverage for automated tests.
dgaikwad
changed the title
dgaikwad
changed the title
dgaikwad
changed the title
dgaikwad
force-pushed
the
test_aws_keypair_list
branch
2 times, most recently
from
c824d1b to
f8ea0f3
Compare
dgaikwad
changed the title
digitronik
reviewed
Jun 16, 2020
Contributor
There was a problem hiding this comment.
Optional: Always better to add finalizer for create operation. I think here you can use delete_if_exists.
Contributor
There was a problem hiding this comment.
optional: When we have BaseEnity object you wan access CollectionEnity with parent.
navigate_to(keypair.parent, 'All')
digitronik
added
the
test-automation
dgaikwad
changed the title
dgaikwad
force-pushed
the
test_aws_keypair_list
branch
from
f8ea0f3 to
366d5d0
Compare
dgaikwad
changed the title
dgaikwad
changed the title
dgaikwad
force-pushed
the
test_aws_keypair_list
branch
from
366d5d0 to
60ec7f8
Compare
Contributor
|
I detected some fixture changes in commit 60ec7f8 The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
dgaikwad
changed the title
digitronik
approved these changes
Jun 18, 2020
digitronik
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding_test test to check key pair able to see or not for custom user when tenant as Parent tenant and Child - tenant
Purpose or Intent
PRT Run
{{pytest: cfme/tests/configure/test_access_control.py -k test_aws_keypair_list --long-running -v}}