This repository was archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Improve email tests.#10177
Merged
mshriver merged 7 commits intoManageIQ:masterfrom Jul 2, 2020
jarovo:cc_emails
Merged
[1LP][RFR] Improve email tests.#10177mshriver merged 7 commits intoManageIQ:masterfrom jarovo:cc_emails
mshriver merged 7 commits intoManageIQ:masterfrom
jarovo:cc_emails
Conversation
mshriver
reviewed
Jul 1, 2020
added 6 commits
July 2, 2020 09:32
It is not always true the port is randomly chosen.
Contributor
|
I detected some fixture changes in commit 5278d32 The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
mshriver
approved these changes
Jul 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
For checking CC and Bcc we need improvement of mock SMTP server we have.
Tests ran on with my jenkins job due to problems with connection to the PRT container:
https://cfmeqe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/downstream-511-tests-jhenner/19/
In above, the virtualcenter provision_approval tests had problems to pass. They seem to be flaky as seen here:
https://cfmeqe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/downstream-511-tests-jhenner/19/testReport/cfme.tests.cloud_infra_common/test_provisioning/
The failure seem not related:
Locally passed: cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[virtualcenter-6.7-edit] PASSED
{{py.test: -sv cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval cfme/tests/configure/test_email.py::test_send_test_email --use-provider complete }}