This repository was archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Fixing TC v2v_custom_attribute#10136
Merged
digitronik merged 1 commit intoManageIQ:masterfrom May 26, 2020
Merged
Conversation
ef66282 to
e4c2803
Compare
Signed-off-by: mnadeem92 <mnadeem@redhat.com>
e4c2803 to
224fbd1
Compare
Contributor
|
It took me a good while, but I think I am beginning to grasp what is going on here. The code used to change more than one field. It happens that change to field, that is not relevant to the test, makes some values in other field, that is relevant, invalid and that breaks the test. The fix here is to change only one relevant field. In total, you are removing bunch of lines and I believe making broken test passing, hopefully still validly. thumbs up |
digitronik
approved these changes
May 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mnadeem92 mnadeem@redhat.com
The Test case was failing as the resources flavor and security group are not available to the cluster.
The Test case is to test the custom attribute flavor and security group by providing a new value for these params other than the default one.
security-group:
default --> provider.data.security_groups.admin[0]
custom value --> provider.data.security_groups.admin[1]
flavor
default --> provider.data.flavors[0]
custom value --> provider.data.flavors[1]
As per TC requirement, we are not required to change the cluster, however in TC cluster gets changed from "admin" to "on-qa" , However the above security-group and flavor is a part of "admin" project and not available in on-qa cluster, This was the main reason for TC failure.
This PR fixing this issue.
{{ pytest: cfme/tests/v2v/test_v2v_migrations_ui.py -k "test_v2v_custom_attribute" --use-provider osp13-ims --use-provider vsphere67-ims --provider-limit 2 -v }}