Skip to content
This repository was archived by the owner on Apr 7, 2022. It is now read-only.

[RFR] Automate: test_dynamic_dialogs_on_service_request#10133

Merged
mshriver merged 2 commits intoManageIQ:masterfrom
valaparthvi:dynamic_dialog_service
May 28, 2020
Merged

[RFR] Automate: test_dynamic_dialogs_on_service_request#10133
mshriver merged 2 commits intoManageIQ:masterfrom
valaparthvi:dynamic_dialog_service

Conversation

@valaparthvi
Copy link
Contributor

Purpose or Intent

  • Adding tests
    1. test_dynamic_dialogs_on_service_request

PRT Run

{{ pytest: cfme/tests/services/test_dialog_element_in_catalog.py -k test_dynamic_dialogs_on_service_request -svvv }}

@valaparthvi valaparthvi added the test-automation To be applied on PR's which are automating existing manual cases label May 20, 2020
@valaparthvi valaparthvi requested a review from niyazRedhat May 20, 2020 13:28
@valaparthvi valaparthvi force-pushed the dynamic_dialog_service branch 6 times, most recently from 49a2c3f to d953f24 Compare May 26, 2020 05:56
@dajoRH dajoRH added needs-lint and removed lint-ok labels May 26, 2020
@valaparthvi valaparthvi force-pushed the dynamic_dialog_service branch from d953f24 to df85f96 Compare May 26, 2020 06:32
@dajoRH
Copy link
Contributor

dajoRH commented May 26, 2020

I detected some fixture changes in commit df85f96

The local fixture service is used in the following files:

  • cfme/tests/services/test_dialog_element_in_catalog.py

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@dajoRH dajoRH added lint-ok and removed needs-lint labels May 26, 2020
@valaparthvi valaparthvi force-pushed the dynamic_dialog_service branch from bfa6880 to dedb31d Compare May 26, 2020 07:28
@valaparthvi valaparthvi changed the title [WIPTEST] Automate: test_dynamic_dialogs_on_service_request [RFR] Automate: test_dynamic_dialogs_on_service_request May 26, 2020
@dgaikwad
Copy link

LGTM

@mshriver mshriver merged commit 37528da into ManageIQ:master May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lint-ok test-automation To be applied on PR's which are automating existing manual cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants