[1LP][RFR] - Adding test to login new user using upper case password in the existing testcase

[dgaikwad]

adding_test Test to login new user and user having password capital case character in the existing testcase and removed test_authorized_users_can_login

Purpose or Intent

PRT Run

{{pytest: cfme/tests/integration/test_db_auth.py -k "test_db_user_pwd" --long-running -v}}

[valaparthvi]

I really like how neatly this has been implemented, but if the user creation is a part of the test, I think it will be better if you put user creation within the test and not as a part of setup i.e. don't use fixture to create user.

Also it kinda looks like it should be a part of smoke test, thoughts on adding a smoke test marker?

[john-dupuy]

@valaparthvi I think it's fine having it in the fixture. I think creating the user is really a part of the setup, and the point of the test is ensuring that the user is able to login. That said, I'd be fine if you want to include the user creation as part of the test, so up to you @dgaikwad.

[dgaikwad]

@valaparthvi @john-dupuy I have added user creation inside test and also put a smoke marker.

[mshriver]

I believe we already have automated coverage for this test.

https://github.com/ManageIQ/integration_tests/blob/master/cfme/tests/integration/test_db_auth.py#L26

test_db_auth is creating a user with a credential randomized by fauxfactory.gen_alpha, which will include lower and uppercase characters.

It doesn't always include an uppercase character, as its randomized.

I think the existing test cases and fixture should be modified to always include a capital letter in the credential, than create a new test case for this.

[mshriver]

I think the automated test coverage already exists, please adjust existing test case and remove this duplicate case.

[dajoRH]

I detected some fixture changes in commit 9fccdd4

The local fixture nonexistent_user is used in the following files:

• cfme/tests/integration/test_db_auth.py
  • test_login_invalid_user

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

[mshriver]

Perfect! Great job using existing parametrization to get the coverage.