This repository was archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][NOTEST][RFR] Add test coverage for Bugzila#10103
Merged
digitronik merged 1 commit intoManageIQ:masterfrom May 19, 2020
Merged
[1LP][NOTEST][RFR] Add test coverage for Bugzila#10103digitronik merged 1 commit intoManageIQ:masterfrom
digitronik merged 1 commit intoManageIQ:masterfrom
Conversation
Gauravtalreja1
force-pushed
the
test_coverage
branch
from
e28e933 to
12ee7c7
Compare
Gauravtalreja1
changed the title
valaparthvi
suggested changes
May 8, 2020
Contributor
valaparthvi
left a comment
valaparthvi
left a comment
There was a problem hiding this comment.
If these tests start in 5.11 and should be ignored for 5.10, put those markers and add startsin in the polarion docstring.
Tests LGTM otherwise.
tpapaioa
reviewed
May 8, 2020
john-dupuy
changed the title
Contributor
|
Moving to WIPTEST based on comments from @tpapaioa and @valaparthvi |
Gauravtalreja1
force-pushed
the
test_coverage
branch
from
12ee7c7 to
0ac55cc
Compare
Gauravtalreja1
force-pushed
the
test_coverage
branch
from
0ac55cc to
b733d78
Compare
Gauravtalreja1
changed the title
Gauravtalreja1
force-pushed
the
test_coverage
branch
2 times, most recently
from
4360e5b to
9246e6d
Compare
Gauravtalreja1
force-pushed
the
test_coverage
branch
from
9246e6d to
dfcd910
Compare
valaparthvi
approved these changes
May 15, 2020
valaparthvi
changed the title
Contributor
|
Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
Manual Coverage for this BZ's
https://bugzilla.redhat.com/show_bug.cgi?id=1807928
https://bugzilla.redhat.com/show_bug.cgi?id=1776684