[1LP][RFR] Fix VM retirement tests and test cleanup

[valaparthvi]

Purpose or Intent

• Fixing
  1. Tests related to VM retirement
  2. Adding selector to test_add_provider_button_accordion so that it doesn't extra tests.
  3. test_reports_invalid_file which was failing because error message changed.
• Removing
  1. Blockers from BZs
  2. test_ui_pinning_after_relog and test_ui_notification_icon

PRT Run

{{ pytest: cfme/tests/infrastructure/test_vm_retirement_rest.py cfme/tests/intelligence/reports/test_import_export_reports_widgets.py::test_reports_invalid_file -vvv }}

[ganeshhubale]

Optional: you can remove BZ from automates.

[ganeshhubale]

Optional: Are you sure about spaces between words?
message = r".*Error during .*upload.*: undefined method `keys.* for .*i.*:String.*"

Can we write like this - message = r".*Error during.*upload.*: undefined method `keys.*for.*i.*:String.*"

[valaparthvi]

Yeah, I think it will be better to leave the space out. Thanks!

[mshriver]

What are we trying to fix here? using .* is making this expression very greedy, if there's an issue with the number of whitespace characters in the string in the UI, we should use \s+ to express "one or more whitespace characters"

[ganeshhubale]

LGTM :)

[dajoRH]

I detected some fixture changes in commit 28de40c4ac5122bca3db9fde9428fcb964a2b27f

The local fixture retire_action is used in the following files:

• cfme/tests/infrastructure/test_vm_retirement_rest.py
  • test_retire_vm_now
  • test_retire_vm_future

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃