[1LP][RFR] Continue swapping EC2 with OpenStack and fix HTTP 503 issues.

[jarovo]

Another piece to saga about stabilization of the db restore tests.

• There was a PR 9959, but more has to be done to see more tests running in release runs as EC2 is disabled on these.
• Also, some tests were still quite flaky. The problem is that the API is probably handled by other process/thread then the web-ui and we may get HTTP 503 while the web UI might be already loaded and responding with HTTP 2xx.

I believe this PR, greatly reduces the problem by blocking until the API responds with some OK result. The API client object cached in the appliance had to be invalidated.

The errors currently on the PRT are not related. Related issue is an exception saying HTTP 503.

[john-dupuy]

LGTM, thanks for this PR 👍

[john-dupuy]

😄

[mshriver]

Hilarious, and great implementation of the wait/check pattern here @JaryN !

[dajoRH]

I detected some fixture changes in commit f493032

The local fixture get_appliances_with_providers is used in the following files:

• cfme/tests/cli/test_appliance_console_db_restore.py
  • test_appliance_console_dump_restore_db_local

The local fixture get_appliance_with_ansible is used in the following files:

• cfme/tests/cli/test_appliance_console_db_restore.py
  • test_appliance_console_restore_pg_basebackup_ansible

The local fixture get_ext_appliances_with_providers is used in the following files:

• cfme/tests/cli/test_appliance_console_db_restore.py
  • test_appliance_console_restore_db_external

The local fixture get_ha_appliances_with_providers is used in the following files:

• cfme/tests/cli/test_appliance_console_db_restore.py

The local fixture two_appliances_one_with_providers is used in the following files:

• cfme/tests/cli/test_appliance_console_db_restore.py
  • test_appliance_console_backup_restore_db_local
  • test_appliance_console_restore_db_nfs
  • test_appliance_console_restore_db_samba

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

[mshriver]

I expect to see Leon Bambrick on all of our cache invalidation calls from now on :)