This repository was archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Automate genealogy tests#10039
Merged
mshriver merged 7 commits intoManageIQ:masterfrom Jun 4, 2020
Merged
Conversation
john-dupuy
reviewed
Apr 7, 2020
john-dupuy
reviewed
Apr 8, 2020
spusateri
force-pushed
the
automate_genealogy_tests
branch
from
6d74d2e to
35d7375
Compare
spusateri
changed the title
fixed fixture scope typo Added InfraVm compare view and toolbar view adding compare genealogy view fix typo
spusateri
force-pushed
the
automate_genealogy_tests
branch
from
35d7375 to
eff3342
Compare
Contributor
|
I detected some fixture changes in commit eff3342 The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
john-dupuy
added
the
test-automation
john-dupuy
suggested changes
Jun 1, 2020
Contributor
john-dupuy
left a comment
john-dupuy
left a comment
There was a problem hiding this comment.
Some small changes, looking good @spusateri!
john-dupuy
changed the title
spusateri
changed the title
john-dupuy
approved these changes
Jun 3, 2020
Contributor
john-dupuy
left a comment
john-dupuy
left a comment
There was a problem hiding this comment.
LGTM, thanks for your work on this @spusateri
john-dupuy
changed the title
mshriver
reviewed
Jun 3, 2020
| try: | ||
| compare_view = create_vm_with_clone[0].genealogy.compare(*create_vm_with_clone) | ||
| assert compare_view.is_displayed | ||
| except ToolbarOptionGreyedOrUnavailable: |
mshriver
approved these changes
Jun 3, 2020
mshriver
approved these changes
Jun 4, 2020
digitronik
reviewed
Jun 4, 2020
| """Fixture to provision a VM and clone it""" | ||
| first_name = fauxfactory.gen_alphanumeric() | ||
| last_name = fauxfactory.gen_alphanumeric() | ||
| email = "{first_name}.{last_name}@test.com" |
Contributor
There was a problem hiding this comment.
I think you want to use f-sting here. Other thought fauxfactory.gen_email()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRT Run
{{ pytest: cfme/tests/cloud_infra_common/test_genealogy.py -k "test_genealogy_comparison" --use-provider vsphere65-nested }}