Skip to content

Fix links in themes.md#5618

Open
abhro wants to merge 3 commits into
MakieOrg:masterfrom
abhro:docs-link
Open

Fix links in themes.md#5618
abhro wants to merge 3 commits into
MakieOrg:masterfrom
abhro:docs-link

Conversation

@abhro
Copy link
Copy Markdown
Contributor

@abhro abhro commented May 2, 2026

Description

Without parentheses it linked to the sections in the page instead of the docstrings in the API page

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
    N/A
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
    N/A
  • Added reference image tests for new plotting functions, recipes, visual options, etc.
    N/A

Without parentheses it linked to the sections in the page instead of the
docstrings in the API page
@github-project-automation github-project-automation Bot moved this to Work in progress in PR review May 2, 2026
@asinghvi17
Copy link
Copy Markdown
Member

Hm shouldn't they link to the page here though? Arguably the API docs should also be here, just condensed...

@abhro
Copy link
Copy Markdown
Contributor Author

abhro commented May 2, 2026

Since the text just before talks about the functions, I figured the docstrings are probably more appropriate. Also, the section headings show up on the right-hand side of the page anyway as part of the table of contents

@SimonDanisch SimonDanisch added the skip-changelog Skips changelog enforcer label May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skips changelog enforcer

Projects

Status: Work in progress

Development

Successfully merging this pull request may close these issues.

3 participants