forked from flutter/flutter
-
Notifications
You must be signed in to change notification settings - Fork 0
Merge master into current branch #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Mairramer
merged 52 commits into
master
from
feature/add-currentIndex-and-onItemChanged-to-carousel
Dec 10, 2025
Merged
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
05d6e89
feat(carousel): add currentIndex to CarouselController and onItemChan…
Mairramer 34ab347
fix docs
Mairramer 59a0819
fix docs
Mairramer b9607f7
improve docs
Mairramer 8c9209e
improves
Mairramer a50ab3d
improves docs
Mairramer e19d243
Merge branch 'master' into feature/add-currentIndex-and-onItemChanged…
Mairramer 7d3d2d1
Merge branch 'master' into feature/add-currentIndex-and-onItemChanged…
Mairramer 9ca3320
small nit
Mairramer 0da4a8c
Merge branch 'master' into feature/add-currentIndex-and-onItemChanged…
Mairramer 2766ab3
improve tests
Mairramer 4518dc8
fix
Mairramer f0266ae
small adjust
Mairramer d6bd04c
improve code
Mairramer 88c0623
improve
Mairramer 97ea420
small fix in doc
Mairramer 552e4d5
refactor
Mairramer 235ecd7
improve docs
Mairramer e234b01
fix small nit
Mairramer b7526e9
Merge branch 'master' into feature/add-currentIndex-and-onItemChanged…
Mairramer bca206e
Merge branch 'master' into feature/add-currentIndex-and-onItemChanged…
Mairramer d87d5c4
fix
Mairramer d5ea0ee
fixes logic
Mairramer 492c3b8
Merge branch 'master' into feature/add-currentIndex-and-onItemChanged…
Mairramer 6a877b7
docs:: update
Mairramer c7602d6
improves
Mairramer bcb5f34
Merge branch 'master' into feature/add-currentIndex-and-onItemChanged…
Mairramer e39651e
Merge branch 'master' into feature/add-currentIndex-and-onItemChanged…
Mairramer 2d5235c
Trigger Build
Mairramer 106f14c
small fix
Mairramer b9123e7
Merge branch 'master' into feature/add-currentIndex-and-onItemChanged…
Mairramer 6ccb494
small adjustments
Mairramer f64dd2e
Add tests for CarouselView's onIndexChanged callback and visibility l…
Mairramer 5f97911
fix
Mairramer c99dda3
Add tests for CarouselView's leadingIndex updates during animations a…
Mairramer d214b4e
fix
Mairramer 3d96eb2
Improve documentation for CarouselController's leadingIndex property
Mairramer 64bcd21
nit
Mairramer 1adeda2
improve docs and fix some behavior
Mairramer 3c3e375
nit
Mairramer b4dea44
Merge branch 'master' into feature/add-currentIndex-and-onItemChanged…
Mairramer 25db08e
improve docs
Mairramer e99a057
Merge branch 'master' into feature/add-currentIndex-and-onItemChanged…
Mairramer 365bda5
small improves
Mairramer 969e481
Merge branch 'master' into feature/add-currentIndex-and-onItemChanged…
Mairramer d9b2020
small improves
Mairramer 217231f
fix
Mairramer b55e410
improve docs
Mairramer 2487749
fix docs
Mairramer 0fde232
fix doc
Mairramer c86c40c
Merge branch 'master' into feature/add-currentIndex-and-onItemChanged…
Mairramer 958f770
Merge branch 'master' into feature/add-currentIndex-and-onItemChanged…
Mairramer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation for
onIndexChangedin aCarouselView.weightedis misleading. It describes the "primary" item (the one with the greatest weight), but the implementation and theleadingItemproperty refer to the item at the leading edge of the viewport, which might not be the primary one. This can cause confusion for developers using this callback. The documentation should be updated to accurately reflect thatonIndexChangedreports the index of the item at the leading edge of the viewport.