-
Notifications
You must be signed in to change notification settings - Fork 146
fix proxy protocol issue and refactored proxyprotocol configuration #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
If helpful, I can provide an architecture diagram plus a ready-to-use values.yaml example showing how to configure PROXY protocol, ingress (TCP/UDP), and the frontend reverse-proxy in a private Kubernetes environment using a modern ingress controller. Say the word and I’ll add the diagram and few explanation. |
|
I have also update readme , default values and missing sieve web port exposure |
|
fix #264 also |
| ## @param front.proxyProtocol.ports.smtps Enable PROXY protocol for SMTPS (465/tcp) | ||
| ## @param front.proxyProtocol.ports.submission Enable PROXY protocol for Submission (587/tcp) | ||
| ## @param front.proxyProtocol.ports.manageSieve Enable PROXY protocol for ManageSieve (4190/tcp) | ||
| ## Enabling any of these requires to have ingress.realIpFrom set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## Enabling any of these requires to have ingress.realIpFrom set | |
| ## Enabling any of these requires to have front.proxyProtocol.realIpFrom set |
Note I'm not a mod, just wanting to use this code too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Great I forgot this doc
| {{- if .Values.ingress.enabled -}} | ||
| {{- $enabledPorts = append $enabledPorts "80" -}} | ||
| {{- $enabledPorts = append $enabledPorts "443" -}} | ||
| {{- $enabledPorts = append $enabledPorts "4190" -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to get 587 into this list for submission to work
otherwise https://github.com/Mailu/Mailu/blob/master/core/nginx/dovecot/proxy.conf#L162 fails
mailu.enabledPorts Feeds into envvars-configmap.yaml Line 117 PORTS that is used in https://github.com/Mailu/Mailu/blob/master/core/base/libs/socrate/socrate/system.py#L144-L147 which would set PORT_587 which the above proxy.conf line uses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem was not with submission, but with managesieve.
With the previous version it would never be deployed when using the ingress controller.
The same issue was written also in other defect.
this pull request fix #518
Problem
What I changed
Why this fixes it
Migration / Upgrade notes
Testing performed
Request for reviewers