Conditionally set PROXY_PROTOCOL and allow for setting collation of DB #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DB_APPENDIX allows appending the collation used for the DB. See Mailu/Mailu#3701
Signed-off-by: Github actions <[email protected]>
DB_APPENDIX allows appending the collation used for the DB. See Mailu/Mailu#3701
Signed-off-by: Github actions <[email protected]>
# Conflicts: # charts/mailu/README.md
This allows for PROXY_PROTOCOL to be defined manually with extraEnvVars for the front pod
Contributor
|
@Grennith Can you rebase your change to the current master? That should fix the CI tests |
github-actions
bot
added
area/charts
Contributor
Author
|
@promasu not sure why the linter is complaining about a missing README update tbh. I did add an entry for appendix accordingly. See https://github.com/Mailu/helm-charts/pull/489/files#diff-3e8fc6668e30f58c499d4d7cd36004d6937cbc884ce7b7af654377a818afd8b3R230 (line 230 of the chart readme). |
Contributor
|
@Grennith Did you manually add it or use the pre-commit-hook? The formatting might be off or smth |
Contributor
Author
|
@promasu yeah I did not set up pre-commit since I reset my notebook. Linter is happy now. Thanks! |
promasu
approved these changes
Oct 19, 2025
DrPsychick
requested changes
Oct 25, 2025
Collaborator
DrPsychick
left a comment
DrPsychick
left a comment
There was a problem hiding this comment.
just formatting, thank you for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves two purposes for which the upstream Mailu repo offers flexibility and support by now
PROXY_PROTOCOLis currently always set by theenvvars-configmap.yaml. If an externalService is not configured, it is empty. However, this breaks the possibility to use Traefik or ingress-nginx to forward TCP traffic to the front service rather than exposing the ports directly. See Proxy Protocol support #264 (comment)DB_APPENDIXto the upstream Mailu repo (see Allow setting collation via env variable and add uvloop Mailu#3729) since the collation of my MariaDB deployment apparently was not accepted anymore with regards to the used collation for the same reason as others have encountered it, see Admin container fails to connect to external MariaDB database Mailu#3449. WithDB_APPENDIX, the sqlalchemy URI can be expanded in case an externalDatabase is used and the collation is not supported for example. For this purpose,.Values.externalDatabase.appendixcan be set. For example,?collation=utf8mb4_unicode_ciworks as a value - further options are also possible as per sqlalchemy