fix: Allows checks for both underscores and dashes as equal

[jshwi]

Fixes open issue: sync-then-check fails with underscores #72

[codecov-commenter]

Codecov Report

Merging #86 (e8fbed6) into master (01356ae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e8fbed6 differs from pull request most recent head 5dbd538. Consider uploading reports for the commit 5dbd538 to get more accurate results

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   94.63%   94.63%           
=======================================
  Files          10       10           
  Lines         745      746    +1     
=======================================
+ Hits          705      706    +1     
  Misses         40       40           

Impacted Files	Coverage Δ
pipenv_setup/inconsistency_checker.py	98.01% <100.00%> (+<0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01356ae...5dbd538. Read the comment docs.

[bryant-finney]

Awesome job! I had a few suggestion; to summarize:

• test_sync_underscore_or_dash() can be simplified a bit further:

  def test_sync_underscore_or_dash(shared_datadir):  # type: (Path) -> None
      """
      sync --pipfile should work for either dash or underscore names.
  
      Asserts fix for https://github.com/Madoshakalaka/pipenv-setup/issues/72.
      """
      with data("dash_or_underscore_0", shared_datadir / "dash_or_underscore_0"):
          cmd(["", "sync", "--pipfile"])
          cmd(["", "check"])

• tests/data/dash_or_underscore_0/Pipfile.lock can be removed
• tests/data/dash_or_underscore_0/pyproject.toml can be removed
• add a hyphenated dependency to tests/data/dash_or_underscore_0/Pipfile for completeness

[jshwi]

@bryant-finney awesome, thanks for the review, I'll check out you found

[jshwi]

@bryant-finney the pyproject.toml was a side effects of pipenv lock, apparently it adds those keys now (or creates a new one if it does not exist).

[jshwi]

I will pull this PR as it is now, and remedy these failed tests.

[jshwi]

I left the other commits in here for completeness. Of course, this can be rebased onto the master branch, or merged, etc. Whatever the preferred strategy is.

[jshwi]

@bryant-finney I've run the test without the change to pipenv_setup/inconsistency_checker.py and it fails, so the test does what we want it to

[bryant-finney]

@jshwi Great 👍 I'll go ahead with squash+merge!