-
Notifications
You must be signed in to change notification settings - Fork 30
package update, add missing dependency chardet #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 2 commits
2da8aa5
56978b3
6cc9f02
8394140
91b93a7
31a4f94
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ dist | |
| .tox/ | ||
| .coverage | ||
| coverage.xml | ||
| .idea/ | ||
|
|
||
| # caches | ||
| .mypy_cache/ | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -5,24 +5,25 @@ verify_ssl = true | |||||
|
|
||||||
| [dev-packages] | ||||||
| pipenv-setup = {editable = true,path = "."} | ||||||
| pytest = {markers = "python_version>='3.6'",version = "~=5.2"} | ||||||
| pytest-mypy = {markers = "python_version>='3.5'",version = "~=0.3"} | ||||||
| pytest-cov = "~=2.7" | ||||||
| pytest-datadir = "~=1.3" | ||||||
| pytest-xdist = "~=1.29" | ||||||
| tox = "~=3.14" | ||||||
| autopep8 = "~=1.4" | ||||||
| pytest = "*" | ||||||
| pytest-mypy = "*" | ||||||
| pytest-cov = "*" | ||||||
| pytest-datadir = "*" | ||||||
| pytest-xdist = "*" | ||||||
| tox = "*" | ||||||
| autopep8 = "*" | ||||||
|
|
||||||
| [packages] | ||||||
| pipfile = "~=0.0" | ||||||
| black = {markers = "python_version>='3.6'",version = "==19.10b0"} | ||||||
| colorama = "~=0.4" | ||||||
| packaging = "~=20.0" | ||||||
| requirementslib = "~=1.5" | ||||||
| vistir = "~=0.4" | ||||||
| autopep8 = {markers = "python_version<'3.6'",version = "~=1.4"} | ||||||
| six = "~=1.12" | ||||||
| typing = {markers = "python_version<'3.7'", version = "~=3.7"} | ||||||
| pipfile = "*" | ||||||
| black = {markers = "python_version>='3.6'",version = "==21.9b0"} | ||||||
|
||||||
| black = {markers = "python_version>='3.6'",version = "==21.9b0"} | |
| black = {markers = "python_version>='3.6'", version="*"} |
Pinning It in the dev extras makes more sense to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I've noticed with black, with is quite frustrating, is that it cannot be unpinned without causing other problems. Pipenv will refuse to install it as a "pre-release" without adding the additional flag. This long traceback can be a bit off-putting for some users. Though easily resolved it could also break any scripts that use Pipenv and do not include this flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup I was able to confirm.
Additional information:
- issue new 'pre' syntax in Pipfile pypa/pipenv#1760 has been open for a few years now
- PR PEEP-007: Accepting pre-releases for specific packages pypa/pipenv#4607 was opened early this year, but I'm unsure of its status
I'm interested if it's feasible to remove black as a minimal dependency. It seems like we could provide it as an extra in one way or another
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where you able to check if any of these packages may have been pinned for a reason?
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [build-system] | ||
| requires = ["setuptools", "wheel"] | ||
| build-backend = "setuptools.build_meta:__legacy__" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍