Do not pin black to avoid conflict with consumers#63
Closed
jbraswell wants to merge 1 commit intoMadoshakalaka:masterfrom
jbraswell:black-wildcard
Closed
Do not pin black to avoid conflict with consumers#63jbraswell wants to merge 1 commit intoMadoshakalaka:masterfrom jbraswell:black-wildcard
jbraswell wants to merge 1 commit intoMadoshakalaka:masterfrom
jbraswell:black-wildcard
Conversation
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 94.63% 93.95% -0.68%
==========================================
Files 10 10
Lines 745 745
==========================================
- Hits 705 700 -5
- Misses 40 45 +5
Continue to review full report at Codecov.
|
Contributor
Author
|
Not sure |
Collaborator
|
This PR looks related to #75 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was forcing us to use an older version of black. Also, because black is still in pre-release, had to add
allow_prereleasestoPipfile.Alternatively, since the code is written to fallback to autopep8 if
import blackfails, we could just remove the dependency on black entirely.