Skip to content

Conversation

@Splines
Copy link
Member

@Splines Splines commented Jun 15, 2025

This PR improves the code quality of our rspec_inside_docker.py script according to Python11 standards.

Note that we still use the VSCode Test Explorer extension in our setup, while in the meantime, VSCode has its own native Test explorer that Ruby LSP can use. In the long-term, we should migrate to this approach. However:

  • Ruby LSP does not support our Docker setup, "only" VSCode dev containers as seen here and we don't migrate to DevContainers soon as discussed in Develop inside a container via Devcontainers #767.
  • Ruby LSP also doesn't offer a custom rspec command. While there is a Ruby LSP addon called Ruby LSP RSpec that does support passing an rspecCommand, this doesn't work for us since it uses Ruby LSP internal commands to report back the results. And since Ruby LSP is still running on the host (VSCode) and not inside the Docker Container, this doesn't work.

For these reasons, we stick to the VSCode Test Explorer extension for now, where we return the test results from the docker container as JSON and the extension reads it and reports it in its custom test explorer view.

For more context, see my comment here. I've also created a gist should there be people that want to use our script as well.

Tip

We should monitor Shopify/ruby-lsp#2919 for future developments on this topic, especially see this comment.

@Splines Splines requested a review from Copilot June 15, 2025 13:11
@Splines Splines self-assigned this Jun 15, 2025

This comment was marked as outdated.

@Splines Splines changed the title Improve code quality of test setup script in Docker container Improve code quality of Docker test setup script Jun 15, 2025
Copy link
Collaborator

@fosterfarrell9 fosterfarrell9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splines Splines merged commit 8b77ce5 into next Jul 5, 2025
2 of 3 checks passed
@Splines Splines deleted the rspec/docker branch July 5, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants