Skip to content

Conversation

@Lestropie
Copy link
Member

Two minor glitches I found in voxel2mesh when diagnosing issues reported by a colleague.

@Lestropie Lestropie added the bug label Dec 2, 2024
@Lestropie Lestropie added this to the 3.0.5 updates milestone Dec 2, 2024
@Lestropie Lestropie requested a review from a team December 2, 2024 12:29
@Lestropie Lestropie self-assigned this Dec 2, 2024
@Lestropie
Copy link
Member Author

For discoverability: what is rectified in f666c76 is that feeding the result to meshfilter would result in "Cannot perform smoothing on this mesh: no triangulation information" from here. The original voxel2mesh -blocky implementation just generated vertices at voxel corners as required, resulting in duplicate vertices; a later change was supposed to re-use existing vertices so that the resulting surface would be closed, but was not functional.

@Lestropie Lestropie added this pull request to the merge queue Feb 6, 2025
Merged via the queue into master with commit 45d970a Feb 6, 2025
5 checks passed
@Lestropie Lestropie deleted the voxel2mesh_fixes branch February 6, 2025 23:50
@Lestropie Lestropie restored the voxel2mesh_fixes branch August 26, 2025 08:11
@Lestropie Lestropie deleted the voxel2mesh_fixes branch August 27, 2025 00:08
@Lestropie Lestropie mentioned this pull request Sep 2, 2025
Lestropie added a commit that referenced this pull request Sep 3, 2025
- #2968: Absent
- #3049: Absent
- #2767: Partially absent
- # 3027: Almost all absent (the new tests were in place but that was all)
- #3047: Absent
- #3071: Absent
- #3011: Fill in gaps of changes that were applied to #3011 prior to its derivation from #2917.
- #2609: Fixed a couple of small omissions.
- #2602: Bits and pieces missing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants