Skip to content

Add new filter: FilterByExpression #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlblancoc merged 4 commits into from
Dec 27, 2025

More code coverage; fix protected-level initalize methods

03fe2f6
Select commit
Loading
Failed to load commit list.
Merged

Add new filter: FilterByExpression #17

More code coverage; fix protected-level initalize methods
03fe2f6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 27, 2025 in 1s

53.62% (+1.06%) compared to 618a3e4

View this Pull Request on Codecov

53.62% (+1.06%) compared to 618a3e4

Details

Codecov Report

❌ Patch coverage is 95.59471% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.62%. Comparing base (618a3e4) to head (03fe2f6).

Files with missing lines Patch % Lines
mp2p_icp_filters/src/FilterByExpression.cpp 95.60% 4 Missing ⚠️
tests/test-mp2p_FilterByExpression.cpp 95.65% 3 Missing ⚠️
mp2p_icp_map/include/mp2p_icp/metricmap.h 81.81% 2 Missing ⚠️
tests/test-mp2p_map_serialization.cpp 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #17      +/-   ##
===========================================
+ Coverage    52.55%   53.62%   +1.06%     
===========================================
  Files          141      144       +3     
  Lines         7135     7320     +185     
  Branches       804      823      +19     
===========================================
+ Hits          3750     3925     +175     
- Misses        3385     3395      +10
Files with missing lines Coverage Δ
.../include/mp2p_icp_filters/FilterAdjustTimestamps.h 100.00% <ø> (ø)
..._icp_filters/include/mp2p_icp_filters/FilterBase.h 0.00% <ø> (ø)
...lters/include/mp2p_icp_filters/FilterBoundingBox.h 100.00% <ø> (ø)
...ters/include/mp2p_icp_filters/FilterByExpression.h 100.00% <100.00%> (ø)
...lters/include/mp2p_icp_filters/FilterByIntensity.h 100.00% <ø> (ø)
...cp_filters/include/mp2p_icp_filters/FilterByRing.h 0.00% <ø> (ø)
.../include/mp2p_icp_filters/FilterDecimateAdaptive.h 0.00% <ø> (ø)
...rs/include/mp2p_icp_filters/FilterDecimateVoxels.h 87.50% <ø> (ø)
...lters/include/mp2p_icp_filters/FilterDeleteLayer.h 100.00% <ø> (ø)
...cp_filters/include/mp2p_icp_filters/FilterDeskew.h 100.00% <ø> (ø)
... and 14 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov