refactor(tests): use devtools fixtures#1130
Merged
wpbonelli merged 1 commit intoMODFLOW-ORG:developfrom Jan 6, 2023
Merged
Conversation
ec58ee7 to
ff486d3
Compare
Contributor
christianlangevin
left a comment
There was a problem hiding this comment.
Looks great, @w-bonelli. Nice cleanup and nice documentation.
ff486d3 to
1db6be0
Compare
1db6be0 to
f366881
Compare
This was referenced Jan 7, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tests that load models from external repos to use devtools fixtures, with a bit of other refactoring. This was carved out of #1066 for a smaller changeset and more incremental refactor.
modflow-devtoolsto:targetsfixture)--model/--packagepytest CLI optionsthere is a package filtering bug in devtools, soon to be fixed in fix(get_packages): fix get_packages(), fix model filtering by package modflow-devtools#44--original-regressionflag as a pytest CLI option/fixture (configured in newconftest.pyfile)DEVELOPER.mdto reflect devtools convention that external model repos live side by side withmodflow6, or optionalREPOS_PATHenvironment variable to specify a different locationbuild_exes.pyandget_exes.py. Give both scripts anargparseCLI with optional--pathargument to specify a different bin path (defaults to the existing location,binin the project root).common_regression.py. A followup PR could replace pymake usages in the rest of the tests.