revert: Disconnect client due to exceeded IP limit#3948
Open
HamidRezaSZ wants to merge 11 commits intoMHSanaei:mainfrom
Open
revert: Disconnect client due to exceeded IP limit#3948HamidRezaSZ wants to merge 11 commits intoMHSanaei:mainfrom
HamidRezaSZ wants to merge 11 commits intoMHSanaei:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the backend IP-limit enforcement job to (1) actively disconnect clients that exceed their allowed IP count and (2) more reliably determine the Xray gRPC API inbound port to avoid “connection refused” errors (as reported in #3895).
Changes:
- Temporarily disconnects clients with excess IPs by removing and re-adding the user via Xray’s gRPC API.
- Resolves the Xray API port by reading the running
config.json, falling back to the storedxrayTemplateConfig, then a default port.
HamidRezaSZ
force-pushed
the
fix/ip-limit
branch
from
09f58c3 to
e718679
Compare
HamidRezaSZ
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the pull request?
I think this commit was a good idea to temporarily disconnect the client and close the old banned IPs. I reverted it and also fixed this issue with retrieving the Xray API inbound port and remove only the client of the inbounds with the supported protocols.
Which part of the application is affected by the change?
Type of Changes
Screenshots