Skip to content

perf: replace /dev/urandom | tr with openssl rand to fix CPU spike in gen_random_string #3887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kookiejarz wants to merge 3 commits into
base: main
Choose a base branch
from
+17 −14
Open

perf: replace /dev/urandom | tr with openssl rand to fix CPU spike in gen_random_string #3887

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b01a71f
Replace random string generation method with OpenSSL for better rando…
Kookiejarz Mar 5, 2026
56af2df
fix: add openssl to install_base deps and fix comment style
Kookiejarz Mar 5, 2026
4348140
update gen_random_string for all three scripts
Kookiejarz Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,12 @@ install_base() {

gen_random_string() {
local length="$1"
local random_string=$(LC_ALL=C tr -dc 'a-zA-Z0-9' </dev/urandom | fold -w "$length" | head -n 1)
echo "$random_string"
# openssl output base64，no need /dev/urandom + tr
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment contains a Chinese full-width comma (，) instead of a standard ASCII comma (,). All other comments in this file use ASCII punctuation. The comment is also somewhat cryptic — consider rephrasing to something clearer like: # Use openssl base64 output instead of /dev/urandom to reduce CPU usage.

Suggested change
# openssl output base64，no need /dev/urandom + tr
# Use openssl base64 output instead of /dev/urandom + tr to reduce CPU usage

Copilot uses AI. Check for mistakes.
openssl rand -base64 $(( length * 2 )) \
| tr -dc 'a-zA-Z0-9' \
| head -c "$length"
}

Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line contains trailing whitespace (4 spaces on a blank line). It should be a clean blank line (or removed entirely) to keep the file tidy, matching the convention of blank lines between functions elsewhere in the file (e.g., line 105 between install_base and gen_random_string).

Suggested change

Copilot uses AI. Check for mistakes.
install_acme() {
echo -e "${green}Installing acme.sh for SSL certificate management...${plain}"
cd ~ || return 1
Expand Down
Loading