Merged
Conversation
Luttik
requested changes
Oct 8, 2021
Owner
There was a problem hiding this comment.
Hi @danygielow,
This is an amazing idea. I personally don't use pre-commit but I believe it is considered the way to go by many. I have two questions for now.
- Is there something that we can add to CI that checks the pre-commit configuration?
- Could you add the changes to the
README.mdalso todocs/index.md(I still need a good way to sync the two and maintain relative URLs within mkdocs)?
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
=======================================
Coverage 73.04% 73.04%
=======================================
Files 5 5
Lines 115 115
Branches 21 21
=======================================
Hits 84 84
Misses 27 27
Partials 4 4 Continue to review full report at Codecov.
|
fb37fa6 to
bc596bb
Compare
Luttik
approved these changes
Oct 8, 2021
Owner
|
Thanks again for your contribution @danygielow I've merged it and a new release action is now running to update the docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for implementing this useful tool.
I'd like to use auto-optional in my projects automatically by adding it to my pre-commit pipeline.
This PR adds a config to be able to use it in pre-commit.
I also added a section to the README describing how to use auto-optional with pre-commit.