AddOpenBehavior(type) now supports stream behaviors without duplicate registrations#860
Merged
jbogard merged 1 commit intoLuckyPennySoftware:masterfrom Feb 28, 2023
Merged
Conversation
asimmon
changed the title
jbogard
approved these changes
Feb 28, 2023
Contributor
Author
|
Hi @jbogard would you consider releasing these changes in a new patch? |
This was referenced Jul 21, 2025
This was referenced Aug 5, 2025
This was referenced Sep 12, 2025
This was referenced Sep 28, 2025
This was referenced Oct 27, 2025
This was referenced Nov 10, 2025
This was referenced Dec 1, 2025
This was referenced Dec 16, 2025
This was referenced Jan 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed:
MediatRServiceConfiguration.AddOpenBehavior(type)assumed that the type parameter implementedIPipelineBehavior<,>. It now supportsIStreamPipelineBehavior<,>and throws anInvalidOperationExceptionthe type parameter is not actually an open behavior. Added multiple tests.TryAddTransientExactwas replaced by the built-inIServiceCollection.TryAddEnumerablethat does the exact same thing, i.e. skip a registration if there's already a service descriptor that exactly match the service type AND implementation type. Modified an existing test to prove that everything behaves as before.MediatRServiceConfiguration.BehaviorsToRegisterconsumption now useTryAddEnumerabletoo. Covered by the modified test from the previous point.Apply the 11.x to 12.x migration guide in test classes: several test open behaviors were not using the right generic constraint, which is now
TRequest : notnull.