Use actual request type in new 'Send' method#844
Merged
jbogard merged 2 commits intoLuckyPennySoftware:masterfrom Feb 15, 2023
Merged
Use actual request type in new 'Send' method#844jbogard merged 2 commits intoLuckyPennySoftware:masterfrom
jbogard merged 2 commits intoLuckyPennySoftware:masterfrom
Conversation
Collaborator
|
Can you add a test for this? So I don't break it again. |
jbogard
approved these changes
Feb 15, 2023
Collaborator
|
I'll wait a bit to see if there are any other bugs before making a release for this. |
This was referenced Sep 28, 2025
This was referenced Oct 27, 2025
This was referenced Nov 10, 2025
This was referenced Dec 1, 2025
This was referenced Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See this old issue for background: #124
It will try to resolve handlers of type "IRequest" instead of using the concrete type of the given request.
sorry I didn't catch that yesterday 😞 let me know if I should add a test