Timeout behavior support#1058
Merged
jbogard merged 4 commits intoLuckyPennySoftware:masterfrom Sep 11, 2024
Merged
Conversation
Closed
|
This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
not stale.. still waiting for feedback and hopeful merge.. |
jbogard
approved these changes
Sep 11, 2024
This was referenced Jul 21, 2025
Closed
Closed
Closed
This was referenced Dec 29, 2025
This was referenced Jan 7, 2026
This was referenced Jan 15, 2026
This was referenced Jan 25, 2026
This was referenced Feb 3, 2026
This was referenced Feb 11, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for creating a timeout behavior.
This PR is in direct response to #1056 , and the long discussion of #592. This was an older issue turned to discussion. I have solved the issue with the below implementation.
The below implementation modifies the
RequestHandlerDelegateto take an optionalCancellationToken. I also modify theRequestHandlerWrapperImplto match the delegate so the casting still works. Then I modify the Aggregation to pass the token into the handle method for the next handler.Usage:
Test Handler:
Unit Test: