Skip to content

Fix Issue #4502 - Confusing exception when trying to map types with … - #4503

Merged
lbargaoanu merged 1 commit into
LuckyPennySoftware:seal_mappersfrom
Biotronic:Fix-4502
Oct 3, 2024
Merged

Fix Issue #4502 - Confusing exception when trying to map types with …#4503
lbargaoanu merged 1 commit into
LuckyPennySoftware:seal_mappersfrom
Biotronic:Fix-4502

Conversation

@Biotronic

@Biotronic Biotronic commented Oct 2, 2024

Copy link
Copy Markdown
Contributor

in parameters in ctor

Fixes #4502.

@lbargaoanu

Copy link
Copy Markdown
Contributor

Revart all the whitespace changes. Assert that the test mapping actually works.

Comment thread src/AutoMapper/Internal/TypePair.cs Outdated
Comment thread src/AutoMapper/ConstructorMap.cs Outdated
@LuckyPennySoftware LuckyPennySoftware deleted a comment from Biotronic Oct 2, 2024
@lbargaoanu
lbargaoanu marked this pull request as draft October 2, 2024 17:00
Comment thread src/UnitTests/Bug/ByrefConstructorParameter.cs Outdated
@Biotronic
Biotronic force-pushed the Fix-4502 branch 2 times, most recently from 4d49084 to 616f4bd Compare October 2, 2024 18:39
@Biotronic Biotronic changed the title Fix Issue #4502 - Confusing exception when trying top map types with … Fix Issue #4502 - Confusing exception when trying to map types with … Oct 2, 2024
Comment thread src/AutoMapper/Internal/TypePair.cs Outdated
Comment thread src/AutoMapper/ConstructorMap.cs Outdated
@lbargaoanu
lbargaoanu changed the base branch from master to seal_mappers October 3, 2024 04:32
@lbargaoanu lbargaoanu closed this Oct 3, 2024
@lbargaoanu lbargaoanu reopened this Oct 3, 2024
@lbargaoanu

lbargaoanu commented Oct 3, 2024

Copy link
Copy Markdown
Contributor

Try the MyGet build.

@lbargaoanu
lbargaoanu marked this pull request as ready for review October 3, 2024 05:05
@lbargaoanu
lbargaoanu merged commit b4331bb into LuckyPennySoftware:seal_mappers Oct 3, 2024
@lbargaoanu lbargaoanu added this to the 14.0.0 milestone Oct 3, 2024
@Biotronic
Biotronic deleted the Fix-4502 branch October 3, 2024 07:25
@Biotronic

Copy link
Copy Markdown
Contributor Author

Works beautifully. :)

@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing exception when trying top map types with in parameters in ctor

2 participants